Create tests for basic hashing; add an API to create opaque pointers #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
mk-opaque
branch
from
91ca44d to
1359bb5
Compare
arthurpaulino
force-pushed
the
mk-opaque
branch
2 times, most recently
from
bbced04 to
dc3a61f
Compare
huitseeker
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Thanks! This PR is a strict improvement.
However, I think it's worth thinking about the places where we could demonstrate the notion of opaque pointers, which I like to think of as non-dereferenceable data:
- the
Writeinstance for the Lurk alphaPtrshows specific typed structure, we'll think whether it's worth integrating such a thing in our pointer representation as we work through the related issue of Support type predicates #658. - Indeed if I look at the difference between this and the Lurk alpha
Opaque, the tag is the main difference:
https://github.com/lurk-lab/lurk-rs/blob/dae0d6c478a83c80e3b3753c29f89e4ecd2a6313/src/ptr.rs#L94-L100 - for now, we can integrate the opaque vocabulary, and probably this function's name in the lem tests
hide_opaque_open_available.
arthurpaulino
force-pushed
the
mk-opaque
branch
from
dc3a61f to
0d05a95
Compare
arthurpaulino
force-pushed
the
mk-opaque
branch
from
0d05a95 to
cd91549
Compare
huitseeker
previously approved these changes
Nov 13, 2023
arthurpaulino
force-pushed
the
mk-opaque
branch
from
cd91549 to
73519aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #878 because I realized that we didn't have tests for the basic cases of
Store::hash_ptr.This PR also shows how to achieve opaque functionality with
ZPtrs.